feat: add hebrew locale support #60

a5r0n · 2024-06-25T23:30:32Z

No description provided.

abichinger

Thank you for your contribution!

Why is the order of the fields different?

Please make sure to follow the contribution guidlines

core/src/locale/he.ts

a5r0n · 2024-06-27T10:15:12Z

Maybe it is an RTL issue, I tried to build and run the demo app, but no success 😕

a5r0n · 2024-06-27T12:49:47Z

@abichinger about the RTL issue, if you can point me with direction how to add rtl support i will be happy to implemnt this in another PR

abichinger · 2024-06-29T14:46:55Z

@a5r0n I have no experience with RTL, so I don't know where to start 🤔

a5r0n · 2024-06-29T17:49:12Z

All we need is to add dir="RTL".
I will try to implement something, should I open new PR for this?

abichinger · 2024-06-29T21:41:11Z

I think no changes are necessary. I just tried to set dir="rtl" on the cron-light component and it seems to work.

<cron-light
    v-model="value"
    v-model:period="period"
    format="quartz"
    locale="he"
    @error="error = $event"
    dir="rtl"
>
</cron-light>

Result:

Is this as it should be?

a5r0n · 2024-06-29T21:58:53Z

Yes, this is great.
I was thinking maybe we should add this as a per language settings, but maybe it's out of the scope

abichinger · 2024-06-30T10:04:00Z

I was thinking maybe we should add this as a per language settings, but maybe it's out of the scope

I think this is out of scope, because of what I have read so far, the dir attribute is usually set on the html tag.

abichinger · 2024-06-30T10:05:41Z

Thanks again!

## [3.0.5](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/ant@3.0.4...@vue-js-cron/ant@3.0.5) (2024-06-30) ### Features * add hebrew locale support ([#60](#60)) ([14b9fbd](14b9fbd))

# [5.2.0](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/core@5.1.0...@vue-js-cron/core@5.2.0) (2024-06-30) ### Features * add hebrew locale support ([#60](#60)) ([14b9fbd](14b9fbd))

abichinger · 2024-06-30T10:08:15Z

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [3.1.2](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/element-plus@3.1.1...@vue-js-cron/element-plus@3.1.2) (2024-06-30) ### Features * add hebrew locale support ([#60](#60)) ([14b9fbd](14b9fbd))

## [4.0.5](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/light@4.0.4...@vue-js-cron/light@4.0.5) (2024-06-30) ### Features * add hebrew locale support ([#60](#60)) ([14b9fbd](14b9fbd))

## [2.0.5](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/naive-ui@2.0.4...@vue-js-cron/naive-ui@2.0.5) (2024-06-30) ### Features * add hebrew locale support ([#60](#60)) ([14b9fbd](14b9fbd))

## [5.0.5](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/vuetify@5.0.4...@vue-js-cron/vuetify@5.0.5) (2024-06-30) ### Features * add hebrew locale support ([#60](#60)) ([14b9fbd](14b9fbd))

abichinger · 2024-06-30T10:08:27Z

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2024-06-30T10:08:33Z

🎉 This PR is included in version 5.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2024-06-30T10:08:39Z

🎉 This PR is included in version 3.1.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2024-06-30T10:08:45Z

🎉 This PR is included in version 4.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2024-06-30T10:08:48Z

🎉 This PR is included in version 2.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2024-06-30T10:08:51Z

🎉 This PR is included in version 5.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

# 1.0.0 (2024-11-14) ### Bug Fixes * *.umd.cjs path ([47e6793](47e6793)) * adapt flavors to new core ([18fc5d0](18fc5d0)) * add periods, remove rank ([7342b12](7342b12)) * add quasar to readme ([500859e](500859e)) * **ant:** migrate to typescript and vite ([54b2443](54b2443)) * **core:** generation of index.d.ts ([8b59bde](8b59bde)) * **core:** set default value ([90e8136](90e8136)) * **core:** set hour range to 0-23 ([b4f3a6d](b4f3a6d)), closes [#5](#5) * **docs:** add base ([b7f673d](b7f673d)) * **docs:** add demo ([e8711c4](e8711c4)) * **element-plus:** migrate to typescript and vite ([7c44b00](7c44b00)), closes [#40](#40) * eslint errors ([8ffe203](8ffe203)) * every n-th segments [#49](#49) ([fca6bba](fca6bba)) * export type CronCoreProps and CronLightProps ([bf5d825](bf5d825)) * fill result of splitArray ([7b09c1e](7b09c1e)) * force release ([f2700ae](f2700ae)) * improve language resolution ([67c8f20](67c8f20)) * interface Period ([4bf8faa](4bf8faa)) * keep no specific value ([2bb9c12](2bb9c12)) * **light:** use vite and typescript ([4f9e524](4f9e524)) * **light:** highlight on hover ([78657e2](78657e2)) * **light:** set text color ([8627362](8627362)) * make selected values reactive [#51](#51) ([bbc5f85](bbc5f85)) * mark quasar/ant as external ([4b18f7e](4b18f7e)) * move vue to devDependencies, ... ([c8ce618](c8ce618)) * **naive-ui:** stop event propagation on clear ([da788a9](da788a9)) * overflow of v-list-item ([866174b](866174b)) * publish vue3 to latest ([2f171a3](2f171a3)) * quartz format error in zh-cn locale ([67f92e8](67f92e8)) * **quartz:** Day-of-Week values must be between 1 and 7 [#62](#62) ([f8cbe3a](f8cbe3a)) * **quasar:** migrate to typescript ([b20f5fb](b20f5fb)), closes [#40](#40) * README ([e4bc6fd](e4bc6fd)) * remove @quasar/vite-plugin ([03c803a](03c803a)), closes [#29](#29) * remove cyclic type ([a632e25](a632e25)) * remove reexport of core.util ([5e86236](5e86236)) * run yarn lint-fix ([5def48b](5def48b)) * **selectedStr:** sort selected values ([1a2be37](1a2be37)), closes [#6](#6) * set period value to period.id ([185e1ec](185e1ec)) * update da.ts [#67](#67) ([a2ce2b7](a2ce2b7)) * Update README ([0228557](0228557)), closes [#26](#26) * update READMEs ([8d5d038](8d5d038)) * use .mjs for rollup config ([1cb1349](1cb1349)) * use language code 'zh' ([a63a5a8](a63a5a8)) * **vuetify:** pass props ([5419124](5419124)) * **vuetify:** migrate to typescript and vite ([f898127](f898127)), closes [#40](#40) * **vuetify:** output css file ([546264e](546264e)) * **vuetify:** select click event ([066edb2](066edb2)) ### Features * add "disabled" option ([ef951fe](ef951fe)), closes [#38](#38) * add @vue-js-cron/prime ([9fd559c](9fd559c)) * add ant ([b53958c](b53958c)) * add china locale ([8248739](8248739)) * add customLocale ([ea80fb9](ea80fb9)) * add danish locale ([5631d9a](5631d9a)) * add element plus ([b4c62b1](b4c62b1)) * add event `update:period` [#47](#47) ([1015ed9](1015ed9)) * add format prop [#25](#25) ([1b42d11](1b42d11)) * add german translation ([e3b7df0](e3b7df0)) * add hebrew locale support ([#60](#60)) ([14b9fbd](14b9fbd)) * add initialPeriod ([dcb7396](dcb7396)) * add isEmpty to useSelect ([3ea62ba](3ea62ba)) * add korean translation ([658ebf0](658ebf0)) * add light package ([48a67dd](48a67dd)) * add Naive UI support [#26](#26) ([3eff0b9](3eff0b9)) * add named exports ([75f7f18](75f7f18)) * add no specific value [#25](#25) ([3beb67f](3beb67f)) * add period prefix and suffix ([d97c081](d97c081)) * add portuguese translation ([64fbe1e](64fbe1e)) * add quasar (vite) ([2b3de8a](2b3de8a)) * add Russian, French, Hindi and Japanese ([7b33b18](7b33b18)) * add spanish locale ([#13](#13)) ([b18d352](b18d352)) * add spring format [#68](#68) ([577e019](577e019)) * core in typescript ([dd33ece](dd33ece)) * **core:** add setupCron and setupSelect ([a4cb6d8](a4cb6d8)) * **core:** export locale, add mergeLocale prop ([bd35287](bd35287)) * **core:** upgrade to vue3 ([96fe7e6](96fe7e6)) * **docs:** upgrade to vuepress@next ([ca8e9be](ca8e9be)) * **element-plus:** add dropdown props [#55](#55) ([2f6aa84](2f6aa84)) * improve initial period selection [#64](#64) ([9321c70](9321c70)) * **light:** add clearable ([b9ca4e2](b9ca4e2)) * **light:** upgrade to vue3 ([2d33143](2d33143)), closes [#4](#4) * translate into typescript ([2f8a214](2f8a214)) * use vuepress instead of docute ([aa66330](aa66330)) * **vuetify:** add chipProps ([d67086a](d67086a)) * **vuetify:** upgrade to vue3 and add CustomSelect ([486d419](486d419)), closes [#4](#4) ### BREAKING CHANGES * - renamed `CronCoreProps.initialPeriod` to `CronCoreProps.period` - removed argument from `setupCron` * **light:** force major release * remove export of util * restructured exports * **vuetify:** no vue2 support * **light:** no vue2 support * **core:** no vue2 support * CronState changed

add hebrew locale support

4057aed

abichinger requested changes Jun 27, 2024

View reviewed changes

core/src/locale/he.ts Outdated Show resolved Hide resolved

a5r0n added 2 commits June 27, 2024 14:32

apply review changes

042a100

apply more changes

3352b2d

fix: run lint-fix

23351ea

abichinger approved these changes Jun 29, 2024

View reviewed changes

docs(demo): add dir attribute

430f91f

abichinger changed the title ~~add hebrew locale support~~ feat: add hebrew locale support Jun 30, 2024

abichinger merged commit 14b9fbd into abichinger:main Jun 30, 2024
1 of 2 checks passed

abichinger added the released label Jun 30, 2024

feat: add hebrew locale support #60

feat: add hebrew locale support #60

Uh oh!

Conversation

a5r0n commented Jun 25, 2024

Uh oh!

abichinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

a5r0n commented Jun 27, 2024

Uh oh!

a5r0n commented Jun 27, 2024

Uh oh!

abichinger commented Jun 29, 2024

Uh oh!

a5r0n commented Jun 29, 2024

Uh oh!

abichinger commented Jun 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

a5r0n commented Jun 29, 2024

Uh oh!

abichinger commented Jun 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

abichinger commented Jun 30, 2024

Uh oh!

abichinger commented Jun 30, 2024

Uh oh!

abichinger commented Jun 30, 2024

Uh oh!

abichinger commented Jun 30, 2024

Uh oh!

abichinger commented Jun 30, 2024

Uh oh!

abichinger commented Jun 30, 2024

Uh oh!

abichinger commented Jun 30, 2024

Uh oh!

abichinger commented Jun 30, 2024

Uh oh!

Uh oh!

abichinger commented Jun 29, 2024 •

edited

Loading

abichinger commented Jun 30, 2024 •

edited

Loading